This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add hidden visibility to internal function prototypes
On Tue, 22 Aug 2017, Florian Weimer wrote:
> On 08/22/2017 12:47 PM, Florian Weimer wrote:
> > I think the attached approach will work for the math subdirectory.
> > Tested on aarch64 and ppc64le.
> >
> > I see additional aarch64 failures, though (outside math).
>
> The failure was spurious (probably clock skew).
>
> I have since tried “make xcheck” and “make bench-build” on both
> architectures and don't see any failures anymore with the patch I posted
> (and the revert reverted).
Thanks. This patch (and restoring HJ's patch) is OK to allow continued
progress on the visibility changes (although the alternative of using
mini-gmp in these tests is attractive as well, in line with the general
principle of limiting tests to using public interfaces when they have no
real need for internal interfaces).
--
Joseph S. Myers
joseph@codesourcery.com