Re: [PATCH] posix: Add compat glob symbol to not follow dangling symbols

[Joseph Myers <joseph at codesourcery dot com>]

On Fri, 15 Sep 2017, Adhemerval Zanella wrote:

> This works as expected with the patch applied.  Since it is for generic
> ABI, default compat symbols are added with override for Linux due LFS.
> Now we have two compat symbols for glob on Linux:
> 
>   1. sysdeps/unix/sysv/linux/oldglob.c which implements glob64 with
>      the old dirent layout.  For this implementation I also set it to
>      follow the no dangling symlinks which is the safest path.
> 
>   2. sysdeps/unix/sysv/linux/glob{64}-lstat-compat.c which implements
>      the compat symbol for dangling symlinks.  As for generic glob,
>      the implementation uses XSTAT_IS_XSTAT64 to define whether
>      both __glob_lstat_compat and __glob64_lstat_compat should be
>      different implementations.  For archictures that define
>      XSTAT_IS_XSTAT64, __glob_lstat_compat is aliased to
>      __glob64_lstat_compat.

3. sysdeps/unix/sysv/linux/alpha/oldglob.c has another compat version for 
a different glob_t layout.  Presumably that one also should ignore 
gl_lstat.

> 	* posix/glob64.c (glob64): Add GLOB_ATTRIBUTE.
> 	* sysdeps/unix/sysv/linux/alpha/libc.abilist: Likewise.

That "Likewise." does not make sense.  I think you want all the abilist 
files together in the ChangeLog.

I also don't see an update of powerpc/powerpc64/libc-le.abilist.

-- 
Joseph S. Myers
joseph@codesourcery.com