This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 4/9] Sync scratch_buffer with gnulib

From: Florian Weimer <fweimer at redhat dot com>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
Cc: Paul Eggert <eggert at cs dot ucla dot edu>
Date: Mon, 18 Sep 2017 08:09:26 +0200
Subject: Re: [PATCH 4/9] Sync scratch_buffer with gnulib
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8945D5AFD9
References: <1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org> <1504643122-14874-5-git-send-email-adhemerval.zanella@linaro.org>

On 09/05/2017 10:25 PM, Adhemerval Zanella wrote:

-  char __space[1024]
-    __attribute__ ((aligned (__alignof__ (max_align_t))));
+  max_align_t __space[(1023 + sizeof (max_align_t)) / sizeof (max_align_t)];

This change needs a declaration from the GCC folks (probably fromRichard Biener) that it does not break aliasing analysis. The old codeuses a GCC extension (writing to a char array changes its dynamic type);it is not valid C. I don't know if the GCC extension also applies ifthe storage site is declared with a non-char type.


Thanks,
Florian

Follow-Ups:
- Re: [PATCH 4/9] Sync scratch_buffer with gnulib
  - From: Adhemerval Zanella

References:
- [PATCH 0/9] posix: glob fixes and refactor
  - From: Adhemerval Zanella
- [PATCH 4/9] Sync scratch_buffer with gnulib
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]