Re: [PATCH] Save final 'error' in __nptl_setxid_error()

[Florian Weimer <fweimer at redhat dot com>]

On 09/19/2017 09:55 AM, Peter Zelezny wrote:
> -      if (olderror != -1)
> +      if (olderror != -1) {
> +	/* save error to memory so it's not lost in coredumps.  */
> +	cmdp->error = error;
>   	/* Mismatch between current and previous results.  */
>   	abort ();
> +	}

Would you please change the formatting so that the { } are on lines by 
themselves (see the surrounding code for examples)?

I think it's better to store the error code in a new local volatile int 
variable, so that both old and new error code are accessible.  The old 
error code seems quite valuable, too.

Thanks,
Florian