This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][malloc] Improve malloc initialization sequence

From: Florian Weimer <fweimer at redhat dot com>
To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "dj at redhat dot com" <dj at redhat dot com>
Cc: nd <nd at arm dot com>
Date: Fri, 29 Sep 2017 21:36:53 +0200
Subject: Re: [PATCH][malloc] Improve malloc initialization sequence
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 114F6C04AC48
References: <DB6PR0801MB205336037693E6A67CDC3EA6837E0@DB6PR0801MB2053.eurprd08.prod.outlook.com>

On 09/29/2017 06:48 PM, Wilco Dijkstra wrote:

       thread attempting to use the arena in parallel waits on us till we
       finish.  */
    __libc_lock_lock (main_arena.mutex);
-  malloc_consolidate (&main_arena);
+  malloc_init_state (&main_arena);

The locking is unnecessary. You should remove it and callmalloc_init_state before the tunables preprocessor conditional.

I believe this fixes bug 22159, so please reference this bug (both inthe commit message and the ChangeLog).


Thanks,
Florian

References:
- [PATCH][malloc] Improve malloc initialization sequence
  - From: Wilco Dijkstra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]