This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 17/58] Mark internal dirent functions with attribute_hidden [BZ #18822]
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: libc-alpha at sourceware dot org
- Date: Sun, 1 Oct 2017 15:23:32 -0700
- Subject: Re: [PATCH 17/58] Mark internal dirent functions with attribute_hidden [BZ #18822]
- Authentication-results: sourceware.org; auth=none
- References: <20170901180029.9527-1-hjl.tools@gmail.com> <20170901180029.9527-18-hjl.tools@gmail.com>
On 9/1/17, H.J. Lu <hjl.tools@gmail.com> wrote:
> Mark internal dirent functions with attribute_hidden to allow direct
> access within libc.so and libc.a without using GOT nor PLT. __readdir64
> is hidden with libc_hidden_proto and libc_hidden_def since the exported
> readdir64 is an alias of __readdir64.
>
> [BZ #18822]
> * include/dirent.h (__opendir): Always add attribute_hidden.
> (__fdopendir): Likewise.
> (__closedir): Likewise.
> (__readdir): Likewise.
> (__readdir64): Add libc_hidden_proto.
> * sysdeps/mach/hurd/readdir64.c (__readdir64): Add libc_hidden_def.
> * sysdeps/unix/sysv/linux/i386/readdir64.c (__readdir64): Likewise.
> * sysdeps/unix/sysv/linux/readdir64.c (__readdir64): Likewise.
> * sysdeps/unix/sysv/linux/wordsize-64/readdir.c (__GI___readdir64):
> New alias.
Tested with build-many-glibcs.py. I am checking it in.
--
H.J.