This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] scripts/test-installation.pl: Ignore nss_test* DSOs [BZ #21911]
- From: Florian Weimer <fweimer at redhat dot com>
- To: Rical Jasan <ricaljasan at pacific dot net>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 10 Oct 2017 11:26:28 +0200
- Subject: Re: [PATCH] scripts/test-installation.pl: Ignore nss_test* DSOs [BZ #21911]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 32EA87EA83
- References: <20170810122423.B1965439942E1@oldenburg.str.redhat.com> <a49eaf6d-4871-b2a1-0ebf-a5854ce11346@pacific.net>
On 10/07/2017 12:55 PM, Rical Jasan wrote:
On 08/10/2017 05:24 AM, Florian Weimer wrote:
2017-08-10 Florian Weimer <fweimer@redhat.com>
[BZ #21911]
* scripts/test-installation.pl: Ignore nss_test* DSOs.
diff --git a/scripts/test-installation.pl b/scripts/test-installation.pl
index c5b9fdefd2..4b0e9f3c4a 100755
--- a/scripts/test-installation.pl
+++ b/scripts/test-installation.pl
@@ -124,7 +124,7 @@ while (<SOVERSIONS>) {
next if ($build_mathvec == 0 && $name eq "mvec");
if ($name ne "nss_ldap" && $name ne "db1"
&& !($name =~/^nss1_/) && $name ne "thread_db"
- && $name ne "nss_test1" && $name ne "libgcc_s") {
+ && $name !~ /^nss_test\d+/ && $name ne "libgcc_s") {
$link_libs .= " -l$name";
$versions{$name} = $version;
}
An anchor would more closely preserve the test (i.e.,
"/^nss_test\d+$/"), and avoid matches like "nss_test9 garb @ g3".
Good point. Updated patch attached.
Thanks,
Florian
2017-10-10 Florian Weimer <fweimer@redhat.com>
[BZ #21911]
* scripts/test-installation.pl: Ignore nss_test* DSOs.
diff --git a/scripts/test-installation.pl b/scripts/test-installation.pl
index 45c666b0a2..74d25e1c8d 100755
--- a/scripts/test-installation.pl
+++ b/scripts/test-installation.pl
@@ -123,7 +123,7 @@ while (<SOVERSIONS>) {
next if ($build_mathvec == 0 && $name eq "mvec");
if ($name ne "nss_ldap" && $name ne "db1"
&& $name ne "thread_db"
- && $name ne "nss_test1" && $name ne "libgcc_s") {
+ && $name !~ /^nss_test\d+$/ && $name ne "libgcc_s") {
$link_libs .= " -l$name";
$versions{$name} = $version;
}