This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3 07/28] arm64/sve: Low-level SVE architectural state manipulation functions
- From: Dave Martin <Dave dot Martin at arm dot com>
- To: Catalin Marinas <catalin dot marinas at arm dot com>
- Cc: linux-arch at vger dot kernel dot org, Okamoto Takayuki <tokamoto at jp dot fujitsu dot com>, libc-alpha at sourceware dot org, Ard Biesheuvel <ard dot biesheuvel at linaro dot org>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>, Richard Sandiford <richard dot sandiford at arm dot com>, Will Deacon <will dot deacon at arm dot com>, Alex Bennée <alex dot bennee at linaro dot org>, kvmarm at lists dot cs dot columbia dot edu, linux-arm-kernel at lists dot infradead dot org
- Date: Wed, 11 Oct 2017 15:39:28 +0100
- Subject: Re: [PATCH v3 07/28] arm64/sve: Low-level SVE architectural state manipulation functions
- Authentication-results: sourceware.org; auth=none
- References: <1507660725-7986-1-git-send-email-Dave.Martin@arm.com> <1507660725-7986-8-git-send-email-Dave.Martin@arm.com> <20171011142819.jheh4jwb347demj6@armageddon.cambridge.arm.com>
On Wed, Oct 11, 2017 at 03:28:19PM +0100, Catalin Marinas wrote:
> On Tue, Oct 10, 2017 at 07:38:24PM +0100, Dave P Martin wrote:
> > Manipulating the SVE architectural state, including the vector and
> > predicate registers, first-fault register and the vector length,
> > requires the use of dedicated instructions added by SVE.
> >
> > This patch adds suitable assembly functions for saving and
> > restoring the SVE registers and querying the vector length.
> > Setting of the vector length is done as part of register restore.
> >
> > Since people building kernels may not all get an SVE-enabled
> > toolchain for a while, this patch uses macros that generate
> > explicit opcodes in place of assembler mnemonics.
> >
> > Signed-off-by: Dave Martin <Dave.Martin@arm.com>
> > Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
>
> (not adding reviewed-by as I haven't checked the instruction encodings,
> I just trust you to be correct ;))
Agreed, I am sometimes correct.
Better, Alex _did_ check the encodings against binutils :)