Re: [PATCH 1/5] manual: Update to mention ENODEV for ttyname and ttyname_r

["Dmitry V. Levin" <ldv at altlinux dot org>]

On Wed, Oct 11, 2017 at 11:53:17PM -0400, Luke Shumaker wrote:
> Commit 15e9a4f3 by Christian Brauner <christian.brauner@canonical.com>
> introduced ENODEV as a possible error condition for ttyname and ttyname_r.
> The manual should mention this.
> ---
>  ChangeLog            | 4 ++++
>  manual/terminal.texi | 5 +++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/ChangeLog b/ChangeLog
> index a3c6b0ab19..cc036f7b88 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,7 @@
> +2017-10-11  Luke Shumaker  <lukeshu@parabola.nu>
> +
> +	* manual/terminal.texi: Mention ENODEV for ttyname and ttyname_r.

I think this should be

	* manual/terminal.texi (Is It a Terminal): ...

> --- a/manual/terminal.texi
> +++ b/manual/terminal.texi
> @@ -109,6 +109,11 @@ The @var{filedes} is not associated with a terminal.
>  @item ERANGE
>  The buffer length @var{len} is too small to store the string to be
>  returned.
> +
> +@item ENODEV
> +The @var{filedes} is valid, and is associated with a terminal, and
> +that terminal is a slave psuedo-terminal, but the associated file name
> +could not be determined.  This is a GNU extension.

Something has to be done with the wording, e.g.

The @var{filedes} argument is a valid file descriptor associated with
a slave psuedo-terminal device, but the file name of that device could
not be determined.  This is a GNU extension.


-- 
ldv

Attachment: signature.asc
Description: PGP signature