This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] sysconf: Fix missing definition of UIO_MAXIOV on Linux [BZ #22321]
- From: Florian Weimer <fweimer at redhat dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 19 Oct 2017 21:21:15 +0200
- Subject: Re: [PATCH] sysconf: Fix missing definition of UIO_MAXIOV on Linux [BZ #22321]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3B413C047B99
- References: <20171019183228.4BD2A428666AA@oldenburg.str.redhat.com> <c084b35a-8ce3-f0f2-c360-167834479f8d@redhat.com>
On 10/19/2017 09:13 PM, Carlos O'Donell wrote:
+ TEST_VERIFY (IOV_MAX == uio_maxiov_value ());
+ TEST_VERIFY (UIO_MAXIOV == uio_maxiov_value ());
+ TEST_VERIFY (sysconf (_SC_UIO_MAXIOV) == uio_maxiov_value ());
+ TEST_VERIFY (sysconf (_SC_IOV_MAX) == uio_maxiov_value ());
Is there an expectation that the value, although consistent,
should not be -1?
e.g.
TEST_VERIFY (IOV_MAX != -1);
TEST_VERIFY (UIOV_MAX != -1);
Do we need to verify it is >= _XOPEN_IOV_MAX?
e.g.
TEST_VERIFY (IOV_MAX >= _XOPEN_IOV_MAX);
TEST_VERIFY (UIOV_MAX >= _XOPEN_IOV_MAX);
Should I add
TEST_VERIFY (uio_maxiov_value () >= _XOPEN_IOV_MAX);
?
That would indirectly cover all the additional tests you suggest.
Thanks,
Florian