This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Clean up iconv/gconv_int.h for unnecessary declarations
- From: Arjun Shankar <arjun dot is at lostca dot se>
- To: libc-alpha at sourceware dot org
- Date: Fri, 27 Oct 2017 15:38:54 +0000
- Subject: Re: [PATCH] Clean up iconv/gconv_int.h for unnecessary declarations
- Authentication-results: sourceware.org; auth=none
- References: <20171027151849.GA95692@aloka.lostca.se>
> This patch removes the extern declarations from the header file and moves
> the definitions to the compilation units where they are used.
One of the context lines in this patch depends on a patch I submitted
yesterday [1]. Nonetheless, it can still be applied by passing '-C2' to
git-apply or git-am. Apologies for the confusion.
I am referring to this hunk in iconv/gconv_conf.c:
> @@ -420,7 +427,7 @@ read_conf_file (const char *filename, const char *directory, size_t dir_len,
>
>
> /* Determine the directories we are looking for data in. */
> -void
> +static void
> __gconv_get_path (void)
> {
> /* Make sure we haven't done it already. */
[1] https://sourceware.org/ml/libc-alpha/2017-10/msg01195.html