This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 5/7] [PowerPC64] strncase_l-power7.c should use strncase_l.c



On 25/10/2017 05:36, Alan Modra wrote:
> This is another one where we'll be wanting the base symbols for
> powerpc64le rather than just a power7 variant.
> 
> 	* sysdeps/powerpc/powerpc64/multiarch/strncase_l-power7.c: Include
> 	string/strncase_l.c, not string/strncase.c.
> 	(USE_IN_EXTENDED_LOCALE_MODEL): Don't define.
> 	(libc_hidden_def): Redefine.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>

> 
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strncase_l-power7.c b/sysdeps/powerpc/powerpc64/multiarch/strncase_l-power7.c
> index f87ff6c..73b967d 100644
> --- a/sysdeps/powerpc/powerpc64/multiarch/strncase_l-power7.c
> +++ b/sysdeps/powerpc/powerpc64/multiarch/strncase_l-power7.c
> @@ -18,8 +18,10 @@
>  #include <string.h>
>  
>  #define __strncasecmp_l __strncasecmp_l_power7
> -#define USE_IN_EXTENDED_LOCALE_MODEL    1
> +
> +#undef libc_hidden_def
> +#define libc_hidden_def(name)
>  
>  extern __typeof (strncasecmp_l) __strncasecmp_l_power7 attribute_hidden;
>  
> -#include <string/strncase.c>
> +#include <string/strncase_l.c>
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]