Re: [PATCH] Assume that _DIRENT_HAVE_D_TYPE is always defined.

[Florian Weimer <fweimer at redhat dot com>]

On 10/30/2017 03:40 PM, Carlos O'Donell wrote:
> On 10/30/2017 06:28 AM, Florian Weimer wrote:
> > References remain in io/fts.c, io/ftw.c, posix/glob.c.  These files
> > are (potentially) externally shared.
> >
> > 2017-10-30  Florian Weimer  <fweimer@redhat.com>
> >
> > 	* elf/ldconfig.c (search_dir): Assume that _DIRENT_HAVE_D_TYPE is
> > 	always defined.
> > 	* io/tst-mkdirat.c (do_test): Likewise.
> > 	* io/tst-mkfifoat.c (do_test): Likewise.
> > 	* io/tst-mknodat.c (do_test): Likewise.
> > 	* locale/programs/charmap-dir.c (charmap_readdir): Likewise.
> > 	* locale/programs/locale.c (select_dirs): Likewise.
> > 	* locale/programs/locarchive.c (add_locales_to_archive): Likewise.
> > 	* posix/bug-glob2.c (my_readdir): Likewise.
> > 	* posix/tst-dir.c (main): Likewise.
> > 	* posix/tst-glob_lstat_compat.c (my_readdir): Likewise.
> > 	* posix/tst-gnuglob-skeleton.c (my_readdir): Likewise.
>
> Everything up to here is OK, and can be committed right away.

Thanks.

> > 	* sysdeps/posix/getcwd.c (__getcwd): Likewise.
>
> Our shared source file list says this comes from 'gnulib':
> https://sourceware.org/glibc/wiki/SharedSourceFiles
>
> Are we able to harmonize this with gnulib?

Not sure if this is a good idea.  We use the generic code as a building 
block for the Linux implementation, and I doubt the gnulib 
implementation will support such abuse.

Thanks,
Florian