This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/6] Filter out NPTL internal signals (BZ #22391)
On 03/11/2017 19:54, Joseph Myers wrote:
> On Fri, 3 Nov 2017, Adhemerval Zanella wrote:
>
>> * signal/sigaddset.c (sigaddset): Likewise.
>> * signal/sigdelset.c (sigdelset): Likewise.
>> * sysdeps/posix/signal.c (__bsd_signal): Likewise.
>> * sysdeps/posix/sigset.c (sigset): Call and check sigaddset return
>> value.
>> * signal/sigfillset.c (sigfillset): User __nptl_clear_internal_signals
>> to filter out internal nptl signals.
>> * signal/tst-sigset.c (do_test): Check ech signal indidually and
>> also check realtime signals using standard macros.
>
> I don't think non-NPTL, non-Linux files like this should be referring to
> NPTL-internal interfaces. You could have some interface for indicating
> "is internal signal" that doesn't refer to NPTL and would equally apply to
> other threading implementations.
>
What about rename linux nptl-signals.h to internal-signals.h, add
a generic version sysdeps/generic instead of sysdeps/nptl, and
rename the __nptl_* function to just __*?