This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v6 6/6] linux ttyname and ttyname_r: Add tests

From: Florian Weimer <fw at deneb dot enyo dot de>
To: Christian Brauner <christian dot brauner at mailbox dot org>
Cc: Luke Shumaker <lukeshu at lukeshu dot com>, libc-alpha at sourceware dot org
Date: Sun, 12 Nov 2017 17:23:31 +0100
Subject: Re: [PATCH v6 6/6] linux ttyname and ttyname_r: Add tests
Authentication-results: sourceware.org; auth=none
References: <20171110200827.32265-1-lukeshu@lukeshu.com> <20171110200827.32265-7-lukeshu@lukeshu.com> <20171112001040.j6aqpk4p24kmi5ww@mailbox.org>

* Christian Brauner:

> Some variable declarations in the middle-of-the stack I pointed out
> before are still left. I don't see this coding style used in the
> codebase a lot but if people don't care and are fine with this I
> don't care.

In new code, we generally tend to reduce the scope of declarative
regions.

Follow-Ups:
- Re: [PATCH v6 6/6] linux ttyname and ttyname_r: Add tests
  - From: Christian Brauner

References:
- [PATCH v6 0/6] Fixup linux ttyname and ttyname_r [BZ #22145]
  - From: Luke Shumaker
- [PATCH v6 6/6] linux ttyname and ttyname_r: Add tests
  - From: Luke Shumaker
- Re: [PATCH v6 6/6] linux ttyname and ttyname_r: Add tests
  - From: Christian Brauner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]