This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] malloc: Add missing arena lock in mallinfo [BZ #22408]
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: DJ Delorie <dj at redhat dot com>
- Cc: fweimer at redhat dot com, libc-alpha at sourceware dot org
- Date: Wed, 15 Nov 2017 10:14:24 +0530
- Subject: Re: [PATCH] malloc: Add missing arena lock in mallinfo [BZ #22408]
- Authentication-results: sourceware.org; auth=none
- References: <xnh8twxknc.fsf@greed.delorie.com>
On Wednesday 15 November 2017 09:23 AM, DJ Delorie wrote:
> I don't feel too strongly about this because the code is the same in the
> end, but it seems like extra work with a weak justification. These are
> the types of requirements that may put off a first-time contributor.
> Obviously this doesn't apply to Florian ;-)
I probably feel stronger about it because of having to sift through
commits that mixed in multiple bug fixes in a past life. For example,
RHEL-5 may want the arena lock fix in malloc_info but may not want the
change in malloc_info output format, in which case downstream will end
up having to figure out which parts should get excluded. In this
particular case it is simple enough to do the separation (which is why I
was OK with the idea of calling the commit as "fixing multiple problems"
but not completely happy), but it can get very complicated very fast.
Siddhesh