Re: [PATCH] copy_file_range: New function to copy file data

[Florian Weimer <fweimer at redhat dot com>]

On 11/19/2017 04:17 AM, Rical Jasan wrote:

> > +@code{errno} error conditions are specific to this function.
>
> "function:"

Fixed.

> > +In addition, @code{copy_file_range} can result with the error codes
>
> "can result in" (or maybe change "result" to something different)

I meant to write “can fail with”.  Fixed.

> > +which are used by @code{read}, @code{pread}, @code{write}, and
> > +@code{pwrite}.
> > +
> > +The @code{copy_file_range} is a cancellation point.  In case of
>
> "The ... function" (or drop "The")

Fixed.

> > +cancellation, the input location (the file position or the value at
> > +@code{@var{inputpos}}) is indeterminate.
>
> Did you mean @code{*@var{inputpos}}?  (That isn't a stamp of approval on
> how we should format dereferencing; I've been arguing with myself over
> that for a long time, but this form at least has precedent, so is fine.)

Yes, the asterisk was missing.

Thank you for your documentation review.

Does anyone want to comment on the implementation? 8-)

Thanks,
Florian