This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] x86-64: Add sinf with FMA
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Mon, 4 Dec 2017 16:38:03 -0200
- Subject: Re: [PATCH] x86-64: Add sinf with FMA
- Authentication-results: sourceware.org; auth=none
- References: <20171204180905.GA31592@gmail.com>
On 04/12/2017 16:09, H.J. Lu wrote:
> On Skylake, bench-sinf reports performance improvement:
>
> Before After Improvement
> max 153.996 100.094 54%
> min 8.546 6.852 25%
> mean 18.1223 14.4616 25%
>
> Any comments?
>
> H.J.
> ---
> * sysdeps/x86_64/fpu/multiarch/Makefile (libm-sysdep_routines):
> Add s_sinf-sse2 and s_sinf-fma.
> (CFLAGS-s_sinf-fma.c): New.
> * sysdeps/x86_64/fpu/s_sinf.S (sinf): Add alias only if __sinf
> is undefined.
> * sysdeps/x86_64/fpu/multiarch/s_sinf-fma.c: New file.
> * sysdeps/x86_64/fpu/multiarch/s_sinf-sse2.S: Likewise.
> * sysdeps/x86_64/fpu/multiarch/s_sinf.c: Likewise.
> ---
> sysdeps/x86_64/fpu/multiarch/Makefile | 5 ++++-
> sysdeps/x86_64/fpu/multiarch/s_sinf-fma.c | 3 +++
> sysdeps/x86_64/fpu/multiarch/s_sinf-sse2.S | 3 +++
With new s_sinf.c generic implementation, does x86_64 still require an
assembly one?