This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] tst-ttyname: skip the test when /dev/ptmx is not available

From: "Dmitry V. Levin" <ldv at altlinux dot org>
To: libc-alpha at sourceware dot org
Date: Mon, 25 Dec 2017 22:12:56 +0300
Subject: Re: [PATCH] tst-ttyname: skip the test when /dev/ptmx is not available
Authentication-results: sourceware.org; auth=none
References: <20171225114806.GB4341@altlinux.org> <87a7y6u0u7.fsf@mid.deneb.enyo.de>

On Mon, Dec 25, 2017 at 07:19:44PM +0100, Florian Weimer wrote:
> * Dmitry V. Levin:
> 
> > * sysdeps/unix/sysv/linux/tst-ttyname.c (do_in_chroot_1): Skip the
> > test instead of failing in case of an error returned by posix_openpt.
> 
> I think the test failure is real in this case.  I wouldn't it be?

No, /dev/ptmx is intentionally missing in the environment where this test
failed.  Do you suggest an explicit check for ENOENT?


-- 
ldv

Attachment: signature.asc
Description: PGP signature

Follow-Ups:
- Re: [PATCH] tst-ttyname: skip the test when /dev/ptmx is not available
  - From: Zack Weinberg

References:
- [PATCH] tst-ttyname: skip the test when /dev/ptmx is not available
  - From: Dmitry V. Levin
- Re: [PATCH] tst-ttyname: skip the test when /dev/ptmx is not available
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]