This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3 12/19] RISC-V: RV32F Support
- From: Darius Rad <darius at bluespec dot com>
- To: Joseph Myers <joseph at codesourcery dot com>, Palmer Dabbelt <palmer at dabbelt dot com>
- Cc: libc-alpha at sourceware dot org, patches at groups dot riscv dot org
- Date: Thu, 4 Jan 2018 13:41:21 -0500
- Subject: Re: [PATCH v3 12/19] RISC-V: RV32F Support
- Authentication-results: sourceware.org; auth=none
- References: <20171227060534.3998-1-palmer@dabbelt.com> <20171227060534.3998-13-palmer@dabbelt.com> <alpine.DEB.2.20.1801011642330.2695@digraph.polyomino.org.uk>
On 01/01/2018 11:51 AM, Joseph Myers wrote:
> On Tue, 26 Dec 2017, Palmer Dabbelt wrote:
>
>> diff --git a/sysdeps/riscv/e_sqrtl.c b/sysdeps/riscv/e_sqrtl.c
>> new file mode 100644
>> index 000000000000..e80a5b0d5b7e
>> --- /dev/null
>> +++ b/sysdeps/riscv/e_sqrtl.c
>> @@ -0,0 +1,39 @@
>> +/* long double square root in software floating-point emulation.
>> + Copyright (C) 1997-2017 Free Software Foundation, Inc.
>> + This file is part of the GNU C Library.
>> + Contributed by Richard Henderson (rth@cygnus.com) and
>> + Jakub Jelinek (jj@ultra.linux.cz).
>
> No "Contributed by" in new files, including where copied from or based on
> existing files (your commit message / ChangeLog entry can note where a
> file is substantially copied from some other existing file).
>
Ok, thanks. I'll remove here and elsewhere.
>> +long
>> +__lroundf (float x)
>> +{
>> + long res;
>
> The glibc style is "long int", not plain "long" (likewise unsigned long
> int, long long int, unsigned long long int). Please check for this
> throughout the patch series.
>
Thanks. I'll change those throughout the series.