This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/2] Avoid using libio internal symbols outside libio & stdio-common.
- From: Zack Weinberg <zackw at panix dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Mon, 8 Jan 2018 10:34:33 -0500
- Subject: Re: [PATCH v2 1/2] Avoid using libio internal symbols outside libio & stdio-common.
- Authentication-results: sourceware.org; auth=none
- References: <20180102034436.11037-1-zackw@panix.com> <5dad9a18-0486-aaad-fda5-4db2cad5d74d@redhat.com>
On Mon, Jan 8, 2018 at 9:36 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 01/02/2018 04:44 AM, Zack Weinberg wrote:
>>
>> Please also carefully review everything that touches on
>> _IO_MTSAFE_IO.
>
> I still think we need to remove _IO_MTSAFE_IO first. I can try to get this
> done by tomorrow, but it's not entirely trivial because we compile some
> parts without it, where it does make a difference. 8-(
>
> I don't think it is a good use of developer time to review _IO_MTSAFE_IO
> changes.
Understood. I don't think we should rush a removal of _IO_MTSAFE_IO.
I think I have an alternative approach that will be far less invasive
- basically, we'll take bits/libio.h out of the installed stdio.h but
we'll include it from include/stdio.h, so code inside libc shouldn't
need to change much at all. I should be able to get *that* done and
tested by tomorrow.
Abstractly, do you think it is worth trying to get an
as-minimal-as-possible removal of libio.h from stdio.h in for 2.27?
zw