Re: [PATCH] Fix uninitialized variable in assert_perror (bug 22761)

["Dmitry V. Levin" <ldv at altlinux dot org>]

On Wed, Jan 31, 2018 at 10:55:44AM +0100, Andreas Schwab wrote:
> I wasn't able to get assert_perror to misbehave in an observable way.
> 
> 	[BZ #22761]
> 	* assert/assert-perr.c (__assert_perror_fail): Append %n to format
> 	string.
> ---
>  assert/assert-perr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/assert/assert-perr.c b/assert/assert-perr.c
> index 002a5e8708..4b4fe883fd 100644
> --- a/assert/assert-perr.c
> +++ b/assert/assert-perr.c
> @@ -32,7 +32,7 @@ __assert_perror_fail (int errnum,
>    char errbuf[1024];
>  
>    char *e = __strerror_r (errnum, errbuf, sizeof errbuf);
> -  __assert_fail_base (_("%s%s%s:%u: %s%sUnexpected error: %s.\n"),
> +  __assert_fail_base (_("%s%s%s:%u: %s%sUnexpected error: %s.\n%n"),
>  		      e, file, line, function);
>  }
>  libc_hidden_def (__assert_perror_fail)

The patch is obviously correct but it breaks translations.
How do we handle this before the release?


-- 
ldv

Attachment: signature.asc
Description: PGP signature