This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [bz 22342] patch: fix netgroup cache keys
- From: Carlos O'Donell <carlos at redhat dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 1 Mar 2018 16:17:40 -0800
- Subject: Re: [bz 22342] patch: fix netgroup cache keys
- Authentication-results: sourceware.org; auth=none
- References: <xnd10ns7pw.fsf@greed.delorie.com>
On 03/01/2018 03:21 PM, DJ Delorie wrote:
> "Carlos O'Donell" <carlos@redhat.com> writes:
>> Why is this correct?
>
> As noted in the referenced BZ, this is the only key in the database that
> doesn't include its trailing NUL. In this particular case, it's
> problematic because there are *two* types of entries in the netgroup
> cache, and when the keys don't match the cache aging and timeouts don't
> work right.
What are the two types of entries? How do they arrive at the database?
What is the other code path that adds the null?
You are -><- close to having what I would want for a good commit message
which explains the exact source of the problem and makes it immediately
obvious that the fix has to be correct.
>> Please post a v2 with the commit message you intend to use
>> please.
>
> Will do.
>
--
Cheers,
Carlos.