This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/6] Remove slow paths from sin/cos
- From: Steve Ellcey <sellcey at cavium dot com>
- To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Fri, 09 Mar 2018 13:50:03 -0800
- Subject: Re: [PATCH 4/6] Remove slow paths from sin/cos
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <DB6PR0801MB2053407B5FE9C9DF2174313683DE0@DB6PR0801MB2053.eurprd08.prod.outlook.com>
- Reply-to: sellcey at cavium dot com
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Fri, 2018-03-09 at 15:50 +0000, Wilco Dijkstra wrote:
> For huge inputs use the improved do_sincos function as well. Now no
> cases use
> the correction factor returned by do_sin, do_cos and TAYLOR_SIN, so
> remove it.
>
> ChangeLog:
> 2018-03-09 Wilco Dijkstra <wdijkstr@arm.com>
>
> * sysdeps/ieee754/dbl-64/s_sin.c (TAYLOR_SIN): Remove cor
> parameter.
> (do_cos): Remove corp parameter and calculations.
> (do_sin): Likewise.
> (do_sincos): Remove cor variable.
> (__sin): Use do_sincos for huge inputs.
> (__cos): Likewise.
> * sysdeps/ieee754/dbl-64/s_sincos.c (__sincos): Likewise.
Did this patch get mangled in transit or something? I could apply
patches 1 through 3 with no problem (and no fuzzing) to ToT but when I
got to 4 I get errors. I may have mangled something on this end but I
treated this patch just like 1 through 3 and those worked fine. 5 and
6 have issues too but I think that is because 4 did not apply cleanly.
Steve Ellcey
sellcey@cavium.com
% patch -p1 < ~/diff.4
patching file sysdeps/ieee754/dbl-64/s_sin.c
Hunk #6 succeeded at 323 (offset -10 lines).
Hunk #7 succeeded at 354 (offset -10 lines).
Hunk #8 succeeded at 384 (offset -10 lines).
Hunk #9 succeeded at 392 (offset -10 lines).
Hunk #10 succeeded at 405 (offset -10 lines).
Hunk #11 succeeded at 440 (offset -10 lines).
Hunk #12 FAILED at 471.
Hunk #13 succeeded at 473 (offset -10 lines).
Hunk #14 succeeded at 488 (offset -10 lines).
1 out of 14 hunks FAILED -- saving rejects to file sysdeps/ieee754/dbl-
64/s_sin.c.rej
patching file sysdeps/ieee754/dbl-64/s_sincos.c
patch: **** malformed patch at line 240: