This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] [BZ 1190] Make EOF sticky in stdio.
- From: Zack Weinberg <zackw at panix dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: Florian Weimer <fweimer at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, Joseph Myers <joseph at codesourcery dot com>, Siddhesh Poyarekar <siddhesh at gotplt dot org>
- Date: Tue, 13 Mar 2018 08:37:14 -0400
- Subject: Re: [PATCH v2] [BZ 1190] Make EOF sticky in stdio.
- Authentication-results: sourceware.org; auth=none
- References: <20180222002306.5998-1-zackw@panix.com> <87zi3c9aks.fsf@linux-m68k.org> <431acf0d-dcfa-95a3-6e75-c26490317e3a@redhat.com> <mvmo9jsmhb5.fsf@suse.de>
On Tue, Mar 13, 2018 at 5:54 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> On Mär 13 2018, Florian Weimer <fweimer@redhat.com> wrote:
>
>> On 03/12/2018 11:46 PM, Andreas Schwab wrote:
>>>> - tst-ftell-append tst-fputws tst-bz22415
>>>> + tst-ftell-append tst-fputws tst-bz22415 tst-fgetc-after-eof \
>>
>>> Spurious backslash.
>>
>> Some of us use this style to avoid spurious -/+ line changes, just to add
>> the backslash in a subsequent patch.
>
> That can easily go wrong.
Without expressing an opinion either way on whether this is good
style, it does not seem to be the practice in libio/Makefile in
general, so I have removed the offending backslash in the version of
the patch I just pushed to master.
zw