This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 1/3] Cleanup __ieee754_sqrt(f/l)


On Wed, 14 Mar 2018, Wilco Dijkstra wrote:

> Unfortunately it's not possible to define _ISOMAC since many tests 
> actually require internal headers, for example the string benchmarks 
> often need inhibit_loop_to_libcall which is defined only if _ISOMAC is 
> not defined.

At least some string tests do (string/test-string.h):

/* We are compiled under _ISOMAC, so libc-symbols.h does not do this
   for us.  */
#include "config.h"
#ifdef HAVE_CC_INHIBIT_LOOP_TO_LIBCALL
# define inhibit_loop_to_libcall \
    __attribute__ ((__optimize__ ("-fno-tree-loop-distribute-patterns")))
#else
# define inhibit_loop_to_libcall
#endif

I'd expect string benchmarks to do similarly (possibly factoring this out 
to a separate header).  That's much better than building them without 
_ISOMAC and so getting *all* the internal header pieces.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]