This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix signed integer overflow in random_r (bug 17343)

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
Date: Fri, 16 Mar 2018 17:26:12 -0700
Subject: Re: Fix signed integer overflow in random_r (bug 17343)
References: <alpine.DEB.2.20.1803161732060.20069@digraph.polyomino.org.uk>

Joseph Myers wrote:

        int32_t val = state[0];
-      val = ((state[0] * 1103515245) + 12345) & 0x7fffffff;
+      val = ((state[0] * 1103515245U) + 12345U) & 0x7fffffff;

The first assignment to VAL (in the unchanged line) is unnecessary; I suggestcoalescing the two lines.

Follow-Ups:
- Re: Fix signed integer overflow in random_r (bug 17343)
  - From: Joseph Myers

References:
- Fix signed integer overflow in random_r (bug 17343)
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]