This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] getlogin_r: return early when linux sentinel value is set

From: Florian Weimer <fweimer at redhat dot com>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Jesse Hathaway <jesse at mbuki-mvuki dot org>
Cc: Andreas Schwab <schwab at linux-m68k dot org>, libc-alpha at sourceware dot org
Date: Tue, 3 Apr 2018 13:44:58 +0200
Subject: Re: [PATCH] getlogin_r: return early when linux sentinel value is set
References: <CANSNSoWLXfsYq6kP0niyP8r25S=S1uTKN=+46xnC_SPLBmKXhQ@mail.gmail.com> <73b04097-ef36-b597-4f7c-2e73c6eb9fa3@linaro.org> <CANSNSoVxHOAM9XZx5ghighXLmXQzSvBfy4xp_FU8=_+U2ZXk8Q@mail.gmail.com> <877eq6ppkw.fsf@linux-m68k.org> <CANSNSoV4Kf_HffDhJboyPrV15P0tL8aB+21ccBz1Anf0q1nb1w@mail.gmail.com> <87370s9fns.fsf@linux-m68k.org> <CANSNSoWK7=NVnjsa4EFrcBwDSfJedNzMsYvKXD_e-M3k6zipRA@mail.gmail.com> <CANSNSoX7WFZm9fUEJ43A=CH8tQ+m7ZtGHqJsAfkY-AOqZbFMzA@mail.gmail.com> <F3EA28F8-B26F-44B3-8447-57AA1E7B203F@linaro.org> <eb5de4c3-d372-ece9-1b82-ad59efd6aa7d@linaro.org> <14b4adaa-22d4-9ef9-198d-8a43484d5567@redhat.com> <9d48f5d8-3465-2003-6ca4-f0deef2891cf@linaro.org>

On 04/03/2018 01:40 PM, Adhemerval Zanella wrote:



On 03/04/2018 07:46, Florian Weimer wrote:

On 03/28/2018 02:37 AM, Adhemerval Zanella wrote:

Pushed upstream.

On 26/03/2018 13:30, Adhemerval Zanella wrote:

I will take care of it today, thanks for remind me.

Sent from my iPhone

On 26 Mar 2018, at 11:22, Jesse Hathaway <jesse@mbuki-mvuki.org> wrote:

On Thu, Mar 22, 2018 at 2:30 PM, Jesse Hathaway <jesse@mbuki-mvuki.org> wrote:
fixed, attached


Adhemerval Zanella would you be able to push this for me?
<getlogin_r.c.patch>


If this has user-visible impact, it should have a bug in Bugzilla, referenced from the ChangeLog entry.

My understanding it is optimization to avoid access nss in
case of invalid uid.


There's a Launchpad bug that suggests a very visible difference in behavior:

https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1760713

Thanks,
Florian

Follow-Ups:
- Re: [PATCH] getlogin_r: return early when linux sentinel value is set
  - From: Adhemerval Zanella

References:
- Re: [PATCH] getlogin_r: return early when linux sentinel value is set
  - From: Florian Weimer
- Re: [PATCH] getlogin_r: return early when linux sentinel value is set
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]