Re: [PATCH 4/4] arm: Enable ARM mode for armv6 strlen

[Adhemerval Zanella <adhemerval dot zanella at linaro dot org>]

On 12/04/2018 13:16, Adhemerval Zanella wrote:
> 
> 
> On 12/04/2018 12:33, Phil Blundell wrote:
>> On Thu, 2018-04-12 at 09:41 -0300, Adhemerval Zanella wrote:
>>> I guess not, but even though the implementation allows it and the
>>> flag usage is wrong.  Another option would just remove ARM code, but
>>> I think for this we will need to also add configure check to require
>>> thumb as well.
>>
>> If the ARM implementation has no benefit (i.e. is no faster than the
>> Thumb one but takes the same/more space) then I think we should delete
>> it.  Having two versions of the code just seems like an unnecessary
>> maintenance headache and source of bugs.
> 
> Agreed.
> 
>>
>> What would the configure check be testing for?  If the target arch is
>> set to armv6t2 (which it must be if we're using this file) then, by
>> definition, Thumb is available.  And the fact that we've apparently
>> been always building the Thumb version in the past seems like a further
>> indication that the use of Thumb here is not a problem.
> 
> I sent the email before I realized armv6t2 always imply in thumb. I think
> for 3rd and 4th patch a better approach would be just to remove the ARM
> path and have one version, I will update them.
> 

In fact for strlen we still require to provide a ARM only mode, since
armv7 build will select this implementation as default and it still
possible the user would require a ARM only build.