This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix path length overflow in realpath (BZ#22786)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Tue, 17 Apr 2018 21:01:08 +0000
- Subject: Re: [patch] Fix path length overflow in realpath (BZ#22786)
- References: <CALoOobOyeu6SM7DGPRqmHE6Y7BckFGmEFGeeFKDKjskL4EJDuA@mail.gmail.com>
On Mon, 9 Apr 2018, Paul Pluzhnikov wrote:
> +# suppress warnings about allocation size.
> +CFLAGS-test-bz22786.c += $(+gcc-nowarn)
I see no current uses of $(+gcc-nowarn) in the source tree. Rather than
resurrecting this variable, we should remove it. Warnings should be
disabled as locally as possible in the sources - meaning using DIAG_* with
appropriate detailed comments around the specific statements generating
warnings, if possible, and failing that, with specific -Wno-* options in
the makefile rather than the extremely blunt -w which would also hide all
valid warnings, not just the one warning you intend to avoid on the one
bit of code for which you intend to avoid it.
--
Joseph S. Myers
joseph@codesourcery.com