This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Questions about failing testcase nptl/test-mutex-printers
- From: Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Cc: Martin Galvan <martin dot galvan at tallertechnologies dot com>, Andi Kleen <ak at linux dot intel dot com>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, raji at linux dot vnet dot ibm dot com, Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- Cc:
- Date: Wed, 18 Apr 2018 11:40:06 -0300
- Subject: Re: Questions about failing testcase nptl/test-mutex-printers
- References: <a40c850a-7e99-9a67-10db-8ec2003f7f1e@linux.vnet.ibm.com>
Stefan Liebler <stli@linux.vnet.ibm.com> writes:
> As I don't have access to other lock-elision enabled machines,
> can somebody test this on power / intel?
Tested on powerpc. Same behavior.
> If I step manually to the tbegin-instruction (which starts the
> transaction on s390x) and step over it, then gdb steps over the whole
> transaction and we are just after the tend-instruction.
That behavior also happens on powerpc with all kinds of transactions.
But it's the GDB behavior with transactions on powerpc.
I don't know the details on s390x.
> Does it make sense to disable lock-elision for the pretty-printer-tests?
> E.g. with the following patch:
> diff --git a/scripts/test_printers_common.py
> b/scripts/test_printers_common.py
> index 73ca525556..d74a8b4d4b 100644
> --- a/scripts/test_printers_common.py
> +++ b/scripts/test_printers_common.py
> @@ -171,6 +171,9 @@ def init_test(test_bin, printer_files, printer_names):
> # Finally, load the test binary.
> test('file {0}'.format(test_bin))
>
> + # Disable lock elision.
> + test('set environment GLIBC_TUNABLES glibc.elision.enable=0')
> +
> def go_to_main():
> """Executes a gdb 'start' command, which takes us to main."""
LGTM.
--
Tulio Magno