This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Replace hidden_def with libm_hidden_def in math
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Tulio Magno Quites Machado Filho <tuliom at linux dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 27 Apr 2018 19:34:15 +0000
- Subject: Re: [PATCH] Replace hidden_def with libm_hidden_def in math
- References: <20180427171618.30576-1-tuliom@linux.ibm.com>
On Fri, 27 Apr 2018, Tulio Magno Quites Machado Filho wrote:
> libm_hidden_def expand the parameters and do not require an extra layer
> of macros.
> These were the last 3 files in math/ still using hidden_def().
>
> 2018-04-27 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
>
> * math/w_exp_compat.c: Replace hidden_def with libm_hidden_def..
> * math/w_expl_compat.c: Likewise.
> * math/w_exp_template.c: Likewise. Remove hidden_def_x.
OK, but without the change
> diff --git a/math/w_expl_compat.c b/math/w_expl_compat.c
> index dda930405e..4e80ce82e3 100644
> --- a/math/w_expl_compat.c
> +++ b/math/w_expl_compat.c
> @@ -22,6 +22,7 @@ static char rcsid[] = "$NetBSD: $";
> * wrapper expl(x)
> */
>
> +#include <libc-symbols.h>
(libc-symbols.h is automatically included via "-include
$(..)include/libc-symbols.h" from Makeconfig, you should never need to
include it explicitly).
--
Joseph S. Myers
joseph@codesourcery.com