Re: [PATCH 1/2] Deprecate sysctl syscall interface

[Adhemerval Zanella <adhemerval dot zanella at linaro dot org>]

On 25/04/2018 14:55, Adhemerval Zanella wrote:
> 
> 
> On 25/04/2018 11:46, Joseph Myers wrote:
>> On Wed, 25 Apr 2018, Adhemerval Zanella wrote:
>>
>>> This patch deprecate sysctl interface by issuing ENOSYS as default
>>
>> That description doesn't make sense, since deprecating is nothing to do 
>> with ENOSYS errors; the ENOSYS handling in this patch is actually a matter 
>> of unification with the generic sysctl implementation.  I think you need 
>> to update the patch description so it accurately describes this version of 
>> the patch.
>>
> 
> What about:
> 
> ---
> 
> This patch deprecates sysctl interface by removing the Linux sysctl.h header,
> adding a compatibility symbol (with previous semantic including returning
> ENOSYS), and avoiding new ports to build and provide the symbol.
> 
> ---
> 

Following Florian's suggestion, I will change to:

* The obsolete function sysctl is no longer available to newly linkerd binaries;
  the header <sys/sysctl.h> has been removed.  This function has been deprecated
  since Linux 2.6.24 in favor of /proc/sys.