Re: [PATCH] Use 64-bit time_t for time zone file parsing

[Paul Eggert <eggert at cs dot ucla dot edu>]

On 05/08/2018 07:29 AM, Florian Weimer wrote:
> Ah. I'm dropping the check of BYTE_ORDER. 

Thanks, this looks good to me. One minor suggestion. This line:

      i = (transitions[num_transitions - 1] - timer) / 15778476;

is now trickier than it used to be. Although the code still works since 
it's just computing a guess, this new behavior might be worth a comment, 
something along the lines "If size_t is 32 bits the assignment to I 
could in theory overflow and wrap around, but this is harmless."