Re: [PATCH 2/2] Y2038: make __tz_convert compatible with 64-bit-time

[Florian Weimer <fweimer at redhat dot com>]

On 06/13/2018 11:36 AM, Albert ARIBAUD wrote:
> Hi Florian,
>
> On Wed, 13 Jun 2018 11:10:09 +0200, Florian Weimer <fweimer@redhat.com>
> wrote :
>
> > On 06/13/2018 09:00 AM, Albert ARIBAUD (3ADEV) wrote:
> > > +  GLIBC_2.28 {
> > > +    __ctime64; __ctime64_r;
> > > +    __gmtime64; __gmtime64_r;
> > > +    __localtime64; __localtime64_r;
> > > +  }
> >
> > Functions in the private namespace should be exported as GLIBC_PRIVATE.
> > Except __gmtime64_r, these functions have unwanted side effects and
> > cannot really be called from other parts of glibc anyway.
>
> They're going to be implementations of APIs called from user source code
> if/when it defines _TIME_BITS equal to 64 (that'll be the last patch in
> the whole series), so I don't understand how they could be considered
> GLIBC_PRIVATE.

Why do they use the __ prefix?  We generally do not do that.

> As for the side effects, which ones are you thinking of? The ones I am
> aware of are those already present in the 32-bit-time versions and are
> "regrettable but established behavior".

The side effects simply mean that we cannot call this functions as an 
internal implementation detail of another function, so there should be 
no reason for an export in the private namespace (with the __prefix and 
GLIBC_PRIVATE).

Thanks,
Florian