This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add renameat2 function [BZ #17662]
Thanks, everything looks good, except for one nit in the NEWS patch, which says:
If the flags are zero, the renameat2 function is implemented using renameat. If the flag is not zero and there is no kernel support for renameat2, the function will fail with an errno value of EINVAL.
If the flags are zero, renameat2 is not always implemented using renameat. Also,
I found that second sentence confusing (it doesn't say what happens if there is
kernel support). How about the following text instead?
---
If the flags are zero, the renameat2 function is equivalent to renameat.
Otherwise, it uses the renameat2 system call if kernel support is available, and
fails with an errno value of EINVAL otherwise.