This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nptl: Use __mprotect consistently for _STACK_GROWS_UP
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 12 Jul 2018 05:52:45 -0700
- Subject: Re: [PATCH] nptl: Use __mprotect consistently for _STACK_GROWS_UP
- References: <20180712124509.8516143994575@oldenburg.str.redhat.com>
On Thu, Jul 12, 2018 at 5:45 AM, Florian Weimer <fweimer@redhat.com> wrote:
> 2018-07-12 Florian Weimer <fweimer@redhat.com>
>
> * nptl/allocatestack.c [_STACK_GROWS_UP] (allocate_stack): Call
> __mprotect, not mprotect.
>
> diff --git a/nptl/allocatestack.c b/nptl/allocatestack.c
> index f9e053f9e5..04e3f08465 100644
> --- a/nptl/allocatestack.c
> +++ b/nptl/allocatestack.c
> @@ -728,7 +728,7 @@ allocate_stack (const struct pthread_attr *attr, struct pthread **pdp,
> /* The guard size difference might be > 0, but once rounded
> to the nearest page the size difference might be zero. */
> if (new_guard > old_guard
> - && mprotect (old_guard, new_guard - old_guard, prot) != 0)
> + && __mprotect (old_guard, new_guard - old_guard, prot) != 0)
> goto mprot_error;
> #endif
>
That is OK.
Thanks.
--
H.J.