This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: V2: [PATCH 01/24] x86: Rename __glibc_reserved1 to feature_1 in tcbhead_t [BZ #22563]
- From: Jeff Law <law at redhat dot com>
- To: Carlos O'Donell <carlos at redhat dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, libc-alpha at sourceware dot org
- Date: Fri, 13 Jul 2018 12:55:31 -0600
- Subject: Re: V2: [PATCH 01/24] x86: Rename __glibc_reserved1 to feature_1 in tcbhead_t [BZ #22563]
- References: <20180613153207.57232-1-hjl.tools@gmail.com> <20180613153207.57232-2-hjl.tools@gmail.com> <20180713131908.GB2606@gmail.com> <663c719e-febe-4884-f814-bf79e2e553ec@redhat.com>
On 07/13/2018 12:51 PM, Carlos O'Donell wrote:
> On 07/13/2018 09:19 AM, H.J. Lu wrote:
>> On Wed, Jun 13, 2018 at 08:31:44AM -0700, H.J. Lu wrote:
>>> This will be used by CET run-time control.
>>>
>>> [BZ #22563]
>>> * nptl/pthread_create.c (__pthread_create_2_1): Use
>>> THREAD_COPY_ADDITONAL_INFO to copy additonal info if defined.
>>> * sysdeps/i386/nptl/tcb-offsets.sym (FEATURE_1_OFFSET): New.
>>> * sysdeps/x86_64/nptl/tcb-offsets.sym (FEATURE_1_OFFSET):
>>> Likewise.
>>> * sysdeps/i386/nptl/tls.h (tcbhead_t): Rename __glibc_reserved1
>>> to feature_1.
>>> * sysdeps/x86_64/nptl/tls.h (tcbhead_t): Likewise.
>>> * sysdeps/unix/sysv/linux/x86/pthreaddef.h: New file.
>>
>> Here is the updated patch to add feature_1 to tcbhead_t and
>> introduce macros for CET enabling. OK for master?
>
> Fix the typo-prone macro API and post a v3 please.
>
> Thank you.
Umm, has this been tested with the sanitizers? I thought they used that
field.
jeff