This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add <bits/indirect-return.h>

From: Joseph Myers <joseph at codesourcery dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Wed, 18 Jul 2018 22:39:49 +0000
Subject: Re: [PATCH] Add <bits/indirect-return.h>
References: <CAMe9rOoLivVEsgjEA3pF1Qyjx2mwNCHaHUFRjv2b2QUDpOB61A@mail.gmail.com>

On Wed, 18 Jul 2018, H.J. Lu wrote:

> +/* __INDIRECT_RETURN is used on swapcontext() to indicate if it

As per the GNU Coding Standards, don't use () to indicate you're referring 
to a function, only when referring to a function call with no arguments.

> +/* On x86, swapcontext() returns via indirect branch when the shadow
> +   stack is enabled.  Define __INDIRECT_RETURN to indicate if
> +   swapcontext() returns via indirect branch.  */

Likewise.

-- 
Joseph S. Myers
joseph@codesourcery.com

References:
- [PATCH] Add <bits/indirect-return.h>
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]