This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix C11 conformance issues

From: Joseph Myers <joseph at codesourcery dot com>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: <libc-alpha at sourceware dot org>
Date: Wed, 25 Jul 2018 15:54:53 +0000
Subject: Re: [PATCH] Fix C11 conformance issues
References: <1532526205-5708-1-git-send-email-adhemerval.zanella@linaro.org> <alpine.DEB.2.20.1807251537160.19155@digraph.polyomino.org.uk>

On Wed, 25 Jul 2018, Joseph Myers wrote:

> On Wed, 25 Jul 2018, Adhemerval Zanella wrote:
> 
> > Checked on i686-linux-gnu and i686-gnu.
> > 
> > 	* include/threads.h: Move to ...
> > 	* sysdeps/nptl/threads.h: ... here.
> > 	* sysdeps/htl/threads.h: New file.
> 
> To confirm: nptl/threads.h, not the wrapper you're moving, still gets 
> correctly installed as threads.h after this patch, while it remains the 
> case that no threads.h is installed for Hurd?

I tested a build as of commit 08ac6bed146c0546d63163ac0d42c9a35880412d.  
This patch has resulted in the wrong threads.h being installed, i.e. 
usr/include/threads.h is now the wrapper that just does #include 
<nptl/threads.h>, which obviously won't work for an installed header.

I think you need to put the real threads.h header in sysdeps/nptl/, not 
the wrapper (with a view to the Hurd work moving both the header, and the 
C11 threads implementation and tests, to sysdeps/pthread/ or some such 
shared location).

-- 
Joseph S. Myers
joseph@codesourcery.com

References:
- [PATCH] Fix C11 conformance issues
  - From: Adhemerval Zanella
- Re: [PATCH] Fix C11 conformance issues
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]