This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix the ld flags not be applied to tst-execstack-mod.so

From: Joseph Myers <joseph at codesourcery dot com>
To: Vineet Gupta <Vineet dot Gupta1 at synopsys dot com>
Cc: Zong Li <zong at andestech dot com>, <libc-alpha at sourceware dot org>, <zongbox at gmail dot com>, arcml <linux-snps-arc at lists dot infradead dot org>
Date: Wed, 25 Jul 2018 20:22:12 +0000
Subject: Re: [PATCH] Fix the ld flags not be applied to tst-execstack-mod.so
References: <1532081682-25895-1-git-send-email-zong@andestech.com> <469dcf75-d652-62ee-8310-ea59ec878a0a@synopsys.com>

On Wed, 25 Jul 2018, Vineet Gupta wrote:

> Chiming in as I'm looking into these things myself in context of testing 
> for ARC port submission. Do we really need to fix this part - in this 
> way. I'd vote to not force the execstack through linker and rely on gcc 
> generating this itself when it knows it doing something for trampolines. 
> And only if target gcc doesn't support it (detected via configure test) 
> should this be done.

The whole point of this test is to verify executable stack changes on 
dlopen of a module requiring an executable stack.  Thus, for this test to 
work correctly, this module must be forced to have a marking as needing an 
executable stack.

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH] Fix the ld flags not be applied to tst-execstack-mod.so
  - From: Vineet Gupta

References:
- [PATCH] Fix the ld flags not be applied to tst-execstack-mod.so
  - From: Zong Li
- Re: [PATCH] Fix the ld flags not be applied to tst-execstack-mod.so
  - From: Vineet Gupta

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]