This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add the statx function
On Jul 26 2018, Florian Weimer <fweimer@redhat.com> wrote:
> On 07/11/2018 12:01 PM, Szabolcs Nagy wrote:
>> On 11/07/18 07:55, Florian Weimer wrote:
>>> On 07/11/2018 08:53 AM, Andreas Schwab wrote:
>>>> /usr/include/sys/stat.h:446:11: fatal error: bits/statx.h: No such
>>>> file or directory
>>>> # include <bits/statx.h>
>>>> ^~~~~~~~~~~~~~
>>>
>>> Okay, so this file should be an installed header. I will commit a fix
>>> after testing.
>>>
>>> Any idea why our header tests do not catch this?
>>>
>>
>> because the glibc source tree does have bits/statx.h
>> and all tests (incorrectly) run with internal headers
>> in the include path (not just the installed ones).
>
> I had hoped that the check-installed-headers-* tests would catch this, but
> clearly that's not the case.
>
>> build-many-glibcs.py catches it though when building gcc
>> (i've just run into this).
>
> Only if GCC uses the header, right? So it's only limited coverage because
> GCC aims to be portable and won't use obscure stuff.
<sys/stat.h> isn't obscure.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."