This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] x86: Rename get_common_indeces to get_common_indices
- From: Carlos O'Donell <carlos at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 26 Jul 2018 20:44:17 -0400
- Subject: Re: [PATCH] x86: Rename get_common_indeces to get_common_indices
- References: <CAMe9rOqfXDarJNUPfzfNOevRNDM+5SMskfY+vWprC0gTCNa2sA@mail.gmail.com>
On 07/26/2018 04:53 PM, H.J. Lu wrote:
> On Thu, Jul 26, 2018 at 1:37 PM, Carlos O'Donell <carlos@redhat.com> wrote:
>> On 07/26/2018 04:32 PM, H.J. Lu wrote:
>>> On Thu, Jul 26, 2018 at 1:05 PM, Carlos O'Donell <carlos@redhat.com> wrote:
>>>> On 07/26/2018 02:07 PM, H.J. Lu wrote:
>>>>> [BZ #23459]
>>>>> * sysdeps/x86/cpu-features.c (get_extended_indeces): New
>>>>> function.
>>>>> (init_cpu_features): Call get_extended_indeces for both Intel
>>>>> and AMD CPUs.
>>>>> ---
>>>>
>>>> OK for 2.28 after you fix the indexes v.s indices issue.
>>>>
>>>> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>>>>
>>>
>>> This is the patch I am checking in.
>>
>> There are *many* incorrect spellings of indices too which you might
>> fix later ;-)
>>
>
> Like this?
Exactly. LGTM. There are still 13 other incorrect spellings in comments,
but they don't really impact much. In this case it's annoying to have a
function spelled incorrectly.
Please wait until 2.29 opens before checking this in, I'd like to minimize
churn at this point.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Cheers,
Carlos.