Re: [PATCH] tst-tzset: raise timeout to 10 seconds

[Florian Weimer <fweimer at redhat dot com>]

On 07/30/2018 06:07 PM, Andreas Schwab wrote:
> On Jul 30 2018, Joseph Myers <joseph@codesourcery.com> wrote:
>
> > On Mon, 30 Jul 2018, Alexey Brodkin wrote:
> >
> > > diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c
> > > index 27f986b56dab..534f7acdf75f 100644
> > > --- a/timezone/tst-tzset.c
> > > +++ b/timezone/tst-tzset.c
> > > @@ -25,7 +25,7 @@
> > >   #include <time.h>
> > >   #include <unistd.h>
> > >   
> > > -#define TIMEOUT 5
> > > +#define TIMEOUT 10
> >
> > The timeout was set to 5 in commit
> > 112f28e88c4ea5afbd6050e71416a23db11e4adc to increase it from a default 2
> > seconds.  That was before the default timeout was changed to 20 seconds in
> > commit a28605b22946c708f0a5c4f06307e1a17650ced8.  In such cases I think we
> > should remove the timeout setting - explicit timeouts less than the
> > default are only appropriate where there is a strong reason to want to
> > *decrease* the default timeout.
>
> There are a lot of tests that set TIMEOUT to less than 20.

We should fix all of them.

Thanks,
Florian