This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCHv2] Fix test failure with -DNDEBUG.

From: Florian Weimer <fweimer at redhat dot com>
To: Carlos O'Donell <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
Date: Thu, 30 Aug 2018 18:24:05 +0200
Subject: Re: [PATCHv2] Fix test failure with -DNDEBUG.
References: <0792219b-b921-2d0e-3102-0095a45fc82f@redhat.com> <e38f0440-3a86-f9f5-981e-800fb547c71c@redhat.com> <9114fb74-7592-bd62-1442-2e9a666972b0@redhat.com>

On 08/30/2018 05:43 PM, Carlos O'Donell wrote:

+	* elf/tst-dlopen-aout.c: Include support/check.h. Use TEST_VERIFY.

Needs updating. “e.g.” in the comment should probably be “that is” or“i.e.”. Looks fine otherwise.


Thanks,
Florian

Follow-Ups:
- Re: [PATCHv2] Fix test failure with -DNDEBUG.
  - From: Carlos O'Donell

References:
- [PATCH] Fix test failure with -DNDEBUG.
  - From: Carlos O'Donell
- Re: [PATCH] Fix test failure with -DNDEBUG.
  - From: Florian Weimer
- [PATCHv2] Fix test failure with -DNDEBUG.
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]