This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: my strstr is broken
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: brunni at netestate dot de, cottrell at wfu dot edu, libc-help at sourceware dot org, GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Tue, 11 Sep 2018 21:08:23 +0530
- Subject: Re: my strstr is broken
- References: <20180910144752.GA29636@netestate.de> <20180911102711.GA31876@netestate.de> <alpine.LNX.2.21.1809110851590.32470@robroy> <20180911135401.GA1745@netestate.de> <CAAHN_R3e0rEgUK5vyKb55QEKmO6+mFVwUQ11w3Ujn97cnmMwkg@mail.gmail.com> <20180911144138.GA2030@netestate.de> <CAAHN_R1PBjz=+NsoA=XCdKcWCi+A-BaG=f29tM9aqyp7+CC_Aw@mail.gmail.com> <CALoOobMRm+OgtuRjOzPCOJFYqNMG1AnMeRXoqcOp8Vc_D_jRmQ@mail.gmail.com>
On Tuesday 11 September 2018 08:51 PM, Paul Pluzhnikov wrote:
This is the second time in my (short) memory strstr got broken with
very long inputs
(https://sourceware.org/bugzilla/show_bug.cgi?id=12092).
There was also https://sourceware.org/bugzilla/show_bug.cgi?id=14602
It seems that testing of strstr is entirely inadequate: (AFAICT) we
only test the IFUNC-selected version, and only on small set of inputs.
I'm not sure about the assertion about not testing IFUNC versions (since
only x86_64 and powerpc seem to be using them and their IFUNC_IMPL
macros look correct to me and should trigger all variants provided the
hardware supports it) but a stress test would be most welcome.
Thanks,
Siddhesh