This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Enable VDSO on statically linked programs.
- From: Rafael Avila de Espindola <rafael at espindo dot la>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Mon, 24 Sep 2018 01:24:39 +0000
- Subject: Re: [PATCH v2] Enable VDSO on statically linked programs.
- References: <Rt9LNuZNJXNeI-mSgZ_YAja7MzVVLO7IYVyN2uyhHcnpBpJH9yzQATx-2GaiHZoMA6mScM6GvrheNFkdCQK4ZGmDbbXhVJ-RI1dp0AGlezA=@espindo.la> <CAMe9rOppStbmn2ti4HyH0HhExbCvrujviE7Xn_o_1ghwyYu5DA@mail.gmail.com>
- Reply-to: Rafael Avila de Espindola <rafael at espindo dot la>
"H.J. Lu" <hjl.tools@gmail.com> writes:
> On Fri, Sep 21, 2018 at 4:40 PM, Rafael Avila de Espindola
> <rafael@espindo.la> wrote:
>> The new version has fixed the indentation of preprocessor directives and changed a few tests to also be linked statically. The tests don't show that the VDSO is being used, but show that the functions now using the VDSO still work.
>>
>
> 2 comments:
>
> 1. Why isn't i386 enabled?
It is probably better to do other architectures as a follow up, no? I do
volunteer to do at least i386.
> 2. ChangeLog entries are missing.
Sorry, it is
2018-09-23 Rafael Ávila de Espíndola <rafael@espindo.la>
* nptl/Makefile: Add tst-cond11-static to tests-static and tests.
* nptl/tst-cond11-static.c: New File.
* sysdeps/unix/sysv/linux/sysdep-vdso.h: remove #ifdef SHARED.
* sysdeps/unix/sysv/linux/x86/libc-vdso.h: remove #ifdef SHARED.
* sysdeps/unix/sysv/linux/x86_64/init-first.c: remove #ifdef SHARED.
* sysdeps/unix/sysv/linux/Makefile: Add tst-affinity-static to
tests-static and tests
* sysdeps/unix/sysv/linux/tst-affinity-static.c: New file.
Cheers,
Rafael