This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/3] posix: Add internal symbols for posix_spawn interface
Hi,
Le Wed, 24 Oct 2018 11:52:41 +0200, Florian Weimer <fweimer@redhat.com>
a écrit :
> * Adhemerval Zanella:
>
> > This patch adds internal hidden definition for mostly of the posix_spawn
> > function so it can be used internally on both popen and system
> > implementations.
> >
> > Checked on x86_64-linux-gnu.
> >
> > * include/spawn.h (__posix_spawn, posix_spawn_file_actions_addclose,
> > __posix_spawn_file_actions_adddup2, __posix_spawn_file_actions_destroy,
> > __posix_spawn_file_actions_init, __posix_spawnattr_init,
> > __posix_spawnattr_destroy, __posix_spawnattr_setflags,
> > __posix_spawnattr_setsigdefault, __posix_spawnattr_setsigmask): New
> > prototype.
> > * posix/spawn.c (__posix_spawn): Add libc_hidden_def.
> > * posix/spawn_faction_addclose.c
> > (__posix_spawn_file_actions_addclose): Add hidden definition.
> > * posix/spawn_faction_adddup2.c
> > (__posix_spawn_file_actions_adddup2): Likewise.
> > * posix/spawn_faction_destroy.c
> > (__posix_spawn_file_actions_destroy): Likewise.
> > * posix/spawn_faction_init.c (__posix_spawn_file_actions_init):
> > Likewise.
> > * posix/spawnattr_destroy.c (__posix_spawnattr_destroy): Likewise.
> > * posix/spawnattr_init.c (__posix_spawnattr_init): Likewise.
> > * posix/spawnattr_setdefault.c (__posix_spawnattr_setsigdefault):
> > Likewise.
> > * posix/spawnattr_setflags.c (__posix_spawnattr_setflags): Likewise.
> > * posix/spawnattr_setsigmask.c (__posix_spawnattr_setsigmask):
> > Likewise.
>
> Looks okay to me.
>
> Thanks,
> Florian
The ChangeLog date on the master branch for this patch is off by one
month (2018-09-24 instead of 2018-10-24).
Cordialement,
Albert ARIBAUD
3ADEV