This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] malloc: Turn unlink_chunk into a function
- From: Andreas Schwab <schwab at suse dot de>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 08 Nov 2018 17:22:05 +0100
- Subject: Re: [PATCH] malloc: Turn unlink_chunk into a function
- References: <87sh0b8t3c.fsf@oldenburg.str.redhat.com>
On Nov 08 2018, Florian Weimer <fweimer@redhat.com> wrote:
> @@ -1489,6 +1456,46 @@ typedef struct malloc_chunk *mbinptr;
> #define bin_index(sz) \
> ((in_smallbin_range (sz)) ? smallbin_index (sz) : largebin_index (sz))
>
> +/* Take a chunk off a bin list. */
> +static void
> +unlink_chunk (mstate av, mchunkptr p)
> +{
> + if (chunksize (p) != prev_size (next_chunk (p)))
Too much indent.
Ok with that change, and please fold with the previous patch.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."