This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4 03/10] RISC-V: Add path of library directories for the 32-bit
- From: Zong Li <zongbox at gmail dot com>
- To: dj at redhat dot com
- Cc: joseph at codesourcery dot com, Palmer Dabbelt <palmer at dabbelt dot com>, darius at bluespec dot com, Andrew Waterman <andrew at sifive dot com>, libc-alpha at sourceware dot org, Zong Li <zong at andestech dot com>
- Date: Mon, 10 Dec 2018 10:43:35 +0800
- Subject: Re: [PATCH v4 03/10] RISC-V: Add path of library directories for the 32-bit
- References: <fcdfbb3d91bfd861336b1cb2a1d0fea343fbad0d.1543572707.git.zongbox@gmail.com> <xnbm5xouag.fsf@greed.delorie.com>
DJ Delorie <dj@redhat.com> 於 2018年12月8日 週六 上午6:18寫道：
>
>
> As much as I hate code duplication, I think we need separate macros for
> 64 and 32 bit targets, else the 32-bit linker will search 64-bit
> libraries and the 64-bit linker will search 32-bit libraries. While the
> linker should be smart enough to skip incompatible libraries, it's
> expensive to do so, and certainly "unexpected" from a developer's point
> of view.
Make sense. It should be separated for rv32 and rv64.
> Zong Li <zongbox@gmail.com> writes:
> > @@ -51,7 +53,14 @@
> > size_t len = strlen (dir); \
> > char path[len + 9]; \
> > memcpy (path, dir, len + 1); \
> > - if (len >= 12 && ! memcmp(path + len - 12, "/lib64/lp64d", 12)) \
> > + if (len >= 13 && ! memcmp(path + len - 13, "/lib32/ilp32d", 13)) \
> > + { \
> > + len -= 9; \
> > + path[len] = '\0'; \
> > + } \
> > + if (len >= 12 \
> > + && (! memcmp(path + len - 12, "/lib32/ilp32", 12) \
> > + || ! memcmp(path + len - 12, "/lib64/lp64d", 12))) \
> > { \
> > len -= 8; \
> > path[len] = '\0'; \
> > @@ -64,6 +73,10 @@
> > add_dir (path); \
> > if (len >= 4 && ! memcmp(path + len - 4, "/lib", 4)) \
> > { \
> > + memcpy (path + len, "32/ilp32d", 10); \
> > + add_dir (path); \
> > + memcpy (path + len, "32/ilp32", 9); \
> > + add_dir (path); \
> > memcpy (path + len, "64/lp64d", 9); \
> > add_dir (path); \
> > memcpy (path + len, "64/lp64", 8); \